Skip to content

Fix grammar typo in Doc/c-api/arg.rst #130741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2025
Merged

Fix grammar typo in Doc/c-api/arg.rst #130741

merged 1 commit into from
Mar 2, 2025

Conversation

@ArijitKD
Copy link
Contributor

@ArijitKD ArijitKD commented Mar 1, 2025 •
edited
Loading

Fix typo: 'extensions functions' -> 'extension functions' in documentation.

📚 Documentation preview 📚: https://cpython-previews--130741.org.readthedocs.build/

@ArijitKD
Fixed a typo in arg.rst
1fcd8cf 
Fix typo: 'extensions functions'  -> 'extension functions' in documentation.
@ghost
Copy link

ghost commented Mar 1, 2025 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 1, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Mar 1, 2025
@picnixz
Copy link
Member

picnixz commented Mar 1, 2025

I think it's a correct fix but I have a doubt now. @python/proofreaders could you confirm this is a typo (I'm not sure if we can have both plural for extension and function/method if there are many extensions and many functions/methods in each of those extensions). Whether it is or not, I would have learned.

@picnixz picnixz changed the title Fixed a typo in arg.rst Fix grammar typo in Doc/c-api/arg.rst Mar 1, 2025
@bskinn
Copy link
Contributor

bskinn commented Mar 1, 2025 •
edited
Loading

I agree, the prior language is incorrect.

This change is solid; after the PR's edit, 'extension' is a nominative, modifying 'functions and methods'.

Another option with essentially the same meaning but a slight change in emphasis would be "your extensions' functions and methods", where "extensions'" becomes a plural possessive attached to 'functions and methods'.

The difference is in the sense of what the 'your' is referring to. In the edit of the PR, it's "your ... functions and methods". In my alternative, it's "your extensions".

+1 to a change, neutral on which.

picnixz
picnixz approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation and the detailed explanation. We'll go with the current change as we avoid the use of ' (which for non-native English speakers may seem as a unusal glyph).

Note: both wordings would be correct.

I'll merge this tomorrow as well.

@picnixz picnixz self-assigned this Mar 1, 2025
@picnixz picnixz merged commit 37145cb into python:main Mar 2, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 2, 2025
@picnixz
Copy link
Member

picnixz commented Mar 2, 2025

Thank you for the PR!

@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 2, 2025
@miss-islington-app
Copy link

Thanks @ArijitKD for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @ArijitKD for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2025
@ArijitKD @miss-islington
Fix grammar typo in Doc/c-api/arg.rst (pythonGH-130741)
976b69e 
(cherry picked from commit 37145cb)

Co-authored-by: Arijit Kumar Das <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 2, 2025

GH-130758 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 2, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2025
@ArijitKD @miss-islington
Fix grammar typo in Doc/c-api/arg.rst (pythonGH-130741)
fa61886 
(cherry picked from commit 37145cb)

Co-authored-by: Arijit Kumar Das <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 2, 2025

GH-130759 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 2, 2025
@hugovk hugovk mentioned this pull request Mar 2, 2025
Merged
hugovk pushed a commit that referenced this pull request Mar 2, 2025
@miss-islington @ArijitKD
[3.13] Fix grammar typo in Doc/c-api/arg.rst (GH-130741) (#130759)
9854566 
Fix grammar typo in `Doc/c-api/arg.rst` (GH-130741)
(cherry picked from commit 37145cb)

Co-authored-by: Arijit Kumar Das <[email protected]>
hugovk pushed a commit that referenced this pull request Mar 2, 2025
@miss-islington @ArijitKD
[3.12] Fix grammar typo in Doc/c-api/arg.rst (GH-130741) (#130758)
96e6932 
Fix grammar typo in `Doc/c-api/arg.rst` (GH-130741)
(cherry picked from commit 37145cb)

Co-authored-by: Arijit Kumar Das <[email protected]>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@ArijitKD @seehwan80
Fix grammar typo in Doc/c-api/arg.rst (python#130741)
8450ea7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Assignees

@picnixz picnixz

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArijitKD @picnixz @bskinn @hugovk